Revert "fix touch offset in window mode" (needs testing)#154
Merged
Conversation
This reverts commit 9eddd5e.
Member
|
Whoa, nice. I haven't been able to reproduce the issue, it was still working after the cleanup, as this commit doesn't have any impact. Thanks for it! |
tito
added a commit
that referenced
this pull request
Sep 16, 2013
Revert "fix touch offset in window mode" (needs testing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9eddd5e.
As per the issue at #153 , the recent commit at bc4a45c caused a touch offset bug. However, the bug could also be fixed by reverting the original fix for at 9eddd5e .
It seems that perhaps the new commit makes the old one redundant by doing the touch offset due to the android status bar somewhere else. That would mean the older fix is now a bug, by repeating the touch offset and making touches be in the wrong place again!
This pull request reverts the original touch fix (now redundant), which seems to resolve the issue. I've tested it successfully, and @denspb confirms at bc4a45c . However, I don't fully understand what's going on behind the scenes, so this PR probably needs confirmation and/or testing by someone familiar with what's really going on.